Addendum to dependency mapping RFC

paketo-buildpacks / rfcs

Apache License 2.0

19 stars 33 forks source link

Addendum to dependency mapping RFC #299

Closed sophiewigmore closed 1 year ago

sophiewigmore commented 1 year ago

Summary

Allow dependency mappings to be in format algorithm-hash in addition to algorithm:hash in order to work on Kubernetes. See for more information https://github.com/paketo-buildpacks/packit/issues/521

Use Cases

Checklist

[X] I have viewed, signed, and submitted the Contributor License Agreement.
[X] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[X] I have reviewed the styleguide for guidance on my code quality.
[X] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

sophiewigmore commented 1 year ago

Note to look into from @anthonydahanne at working group - are there any algorithms that contain a -? That would be an issue for this implementation

sophiewigmore commented 1 year ago

Hmmm - so sha256 can also be represented as SHA-256 or md5 can be MD-5. We might need to rethink using a - - @ChuckQuinnIV cc @anthonydahanne

ChuckQuinnIV commented 1 year ago

Fair point - do we want to adjust this to use _ instead of -? Underscore should also be valid in both Kubernetes & Windows

sophiewigmore commented 1 year ago

@ChuckQuinnIV that works, it looks like it should work on Windows. @paketo-buildpacks/tooling-maintainers any concerns with using a _ instead of -?

robdimsdale commented 1 year ago

@ChuckQuinnIV that works, it looks like it should work on Windows. @paketo-buildpacks/tooling-maintainers any concerns with using a _ instead of -?

If it works then I'm happy. I don't see any obvious concerns (assuming _ is not also used in algorithms 😅 )

sophiewigmore commented 1 year ago

@robdimsdale not that I've seen

sophiewigmore commented 1 year ago

@paketo-buildpacks/steering-committee am I good to merge this in?