ignore empty string class name when building dataflow metadata

paketo-buildpacks / spring-boot

A Cloud Native Buildpack that contributes Spring Boot dependency information and slices an application into multiple layers

Apache License 2.0

164 stars 21 forks source link

ignore empty string class name when building dataflow metadata #454

Closed tinedel closed 3 months ago

tinedel commented 3 months ago

Summary

Fixes issue #438 A lot of properties generated by configuration metadata do not have sourceType field set, which in turn matches the empty class name for the case when a list of classes has a trailing comma in the config file.

Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

linux-foundation-easycla[bot] commented 3 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: tinedel (731ef6c70b00b926742767e0a356f2e0ca46cb44, 0f0a654a274ec52fba193f7a0e86373fa9dace7e, ef27fa98d08c47ef4d2f07feaaeeec0cf6c7b303, d4ee3db77cbba10901e82740e1edffd88f933aa8)

anthonydahanne commented 3 months ago

@kohlmu-pivotal are you ok with this change?

anthonydahanne commented 3 months ago

thanks @tinedel for your contribution! I'm checking if that does indeed fix #438

Also, we're in the middle of dual arch changes, let's wait for this to finish before we merge this one

tinedel commented 3 months ago

@anthonydahanne sure, no problem.

Please let me know when you are ready and I'll update my branch with the latest main

kohlmu-pivotal commented 3 months ago

@kohlmu-pivotal are you ok with this change?

@anthonydahanne , yes I'm ok with this change. Ignore empty class names is what I would have done as well.