I don't have a great mental model of how the Dockerfile is used in the stack creation process, specifically whether this change could cause issues for any older images. I don't see how this could be a problem as the URL for yj is now invalid, even if re-building older images, as it references the latest version.
Instead of using the latest version, we could pin to a specific version, but that seems less useful.
Checklist
[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).
In #128 it was reported that
yjis not present on recent images. This is because as of releasev5.1.0ofyjthe name of the binary changed fromyj-linuxtoyj-linux-amd64. Therefore the new URL is: https://github.com/sclevine/yj/releases/latest/download/yj-linux-amd64.I don't have a great mental model of how the Dockerfile is used in the stack creation process, specifically whether this change could cause issues for any older images. I don't see how this could be a problem as the URL for
yjis now invalid, even if re-building older images, as it references thelatestversion.Instead of using the latest version, we could pin to a specific version, but that seems less useful.
Checklist