Remove deprecated ioutil package.

paketo-buildpacks / stacks

stacks

Apache License 2.0

35 stars 23 forks source link

Remove deprecated ioutil package. #137

Closed robdimsdale closed 2 years ago

robdimsdale commented 2 years ago

Summary

Remove references to now-deprecated ioutil package.

Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

robdimsdale commented 2 years ago

I see that the create-stack test is failing, but I am not able to re-trigger it and it's not obvious to me that this failure is related to my PR.

robdimsdale commented 2 years ago

I think it's related to #82

sophiewigmore commented 2 years ago

@robdimsdale right, the issue is with authenticating when the PR is a fork. Unfortunately the workaround is to point the PR at a non-main branch, merge it in, and then open a new PR from workaround branch to main.

robdimsdale commented 2 years ago

@sophiewigmore given that, any objections to merging this?

brayanhenao commented 2 years ago

@robdimsdale I merge this pr into an intermediate branch since the authentication steps don't work from forks.