paketo-buildpacks / yarn

Apache License 2.0
2 stars 11 forks source link

Updates buildpack.toml with 1.22.22 #617

Closed paketo-bot closed 3 months ago

paketo-bot commented 3 months ago

616

sophiewigmore commented 3 months ago

@mhdawson it's failing to download yarn from deps.paketo.io. Our options are to release a buildpack that only has one version of Yarn in the interim (1.22.22) or do nothing and wait for our bucket to hopefully get fixed

mhdawson commented 3 months ago

@sophiewigmore, we had spoken to the yarn maintainer about getting that fixed and I'm ok with it just supporting a single one for now, but what I wanted to understand is the failures in the integration tests.

Will those continue to fail or is it a bootstrap like issue where after your PR lands the tests will pass again?

sophiewigmore commented 3 months ago

The test is failing because it can't access 1.22.19 from deps.paketo.io. If we remove that version from the buildpack.toml the tests will work

sophiewigmore commented 3 months ago

@mhdawson ^

mhdawson commented 3 months ago

Just confused because I thought that is what your PR is doing, but the tests still fail. Maybe the tests are not using the latest. I'll merge and we can always back out if the tests don't test afterwards

mhdawson commented 3 months ago

ah I see you removed one but not both, can you remove one that is failing as well?

sophiewigmore commented 3 months ago

@mhdawson yes! just wanted to make sure you're OK with shipping a buildpack with just one version first!

mhdawson commented 3 months ago

@sophiewigmore I think given that people are completely broken otherwise, and that it sounds like that might not be fixed in the short term its likely the best of sub-optimal choices.

sophiewigmore commented 3 months ago

@mhdawson I've done one better - we switched to a new bucket a while ago for dependencies that are compiled (artifacts.paketo.io) which is still working. I just took the Yarn dependency for 1.22.19 and uploaded it there, and then updated the URI.

Now we don't have to remove it from the buildpack.toml and it's available for download!

felipe-vicente commented 3 months ago

thank you @sophiewigmore @mhdawson 🙌