Closed mhdawson closed 1 year ago
There are many changes needed to get this into the same form as the other stacks.
It is based on the pattern used for existing stack but the need to build multiple run images when using extensions means that we had to modify the existing patten to handle that. We've done that by duplicating the create script along with the stack directories, one for each run image needed as well one for the base stacks that will be specified in the builder itself.
This is what we used to generate the images that I used in the instructions for testing out the Node.js ubi extension in - https://github.com/paketo-community/ubi-nodejs-extension#usage.
Ideally we could work with somebody who worked on implementing the existing stacks so that we can discuss how best to handle the need for multiple run images and modifying to publish into the paketo docker namespace instead of manually pushing into quay in my namespace which I used as a temporary measure.
I'll take a look at this soon!
@sophiewigmore I think I've updated to address all of your original suggestions/comments and have created the the initial worflows based on our discusison today.
I think I'll need to be able to run the workflows to be able to figure out what's not right. For example I'm hoping the download action will let me specify the name used for the download using path
but I'm not sure from the documentation.
Can you take a look at the updates and let me know what else I should update or do before the next step of landing/running to test out?
@sophiewigmore realized I could test these actions in my own repo since unlike others I've worked on recently they don't depend on issues or PRs from the main repo.
From that testing I fixed up some problems and the action ran to completion and create the release in my repo. You can see the succesfull action run here - https://github.com/mhdawson/ubi-base-stack/actions/runs/5159508696
So at this point I'm a lot more confident that the actions are correct.
This is looking good, I checked out the workflow run you linked. I'll put my approval on since I'm heading out for the day shortly so you can merge this in when you are ready so you're not blocked on workflow development, however I'd like to see Arjun's comment addressed as well before we merge in. I think in subsequent PRs we'll still need to:
@arjun024 @sophiewigmore I think I've now addressed all of the comments.
@arjun024 waiting to merge until we have a 👍 from you as well
Summary
Use Cases
Checklist