search

paketo-community / ubi-base-stack

Apache License 2.0
2 stars 5 forks source link

Updates github-config #11

Closed paketo-bot closed 11 months ago

sophiewigmore commented 11 months ago

@mhdawson based on the changes here I don't think the .syncignore you added in #9 worked properly. A lot of the files in this PR are files we don't want synced. For the workflow files, the path in the .syncignore should be: workflows/create-release.yml (rather than .github/workflows/create-release.yml)

Also, for scripts, you should create a separate .syncignore at scripts/.syncignore, and the paths to the files should be local to the .syncignore like tests.sh (rather than scripts/test.sh).

sophiewigmore commented 11 months ago

cc @pacostas and @robdimsdale for context

mhdawson commented 11 months ago

@sophiewigmore thanks for the ping, will try to take another look to figure out what I've missed.

mhdawson commented 11 months ago

@sophiewigmore thanks for the detailed explanation of what I needed to fix up - PR to make those changes are in https://github.com/paketo-community/ubi-base-stack/pull/12