Updates github-config - Githubissues

paketo-community / ubi-base-stack

Apache License 2.0

2 stars 5 forks source link

Updates github-config #14

Closed paketo-bot closed 11 months ago

sophiewigmore commented 11 months ago

@mhdawson sorry I didn't get to review your syncignore update PR in time. I have some questions

scripts/load-images-to-quay.sh and scripts/load-images-to-local-repository.sh are deleted. Is that intentional?
scripts/receipts.sh was added - do we want that?

mhdawson commented 11 months ago

@sophiewigmore

scripts/load-images-to-quay.sh and scripts/load-images-to-local-repository.sh are deleted. Is that intentional?

This is intentional. @pacostas it was time to remove those two and figured why not let the automation do that.

scripts/receipts.sh

That I don't think we need. I'll creat a PR to update the automation to remove that? Will it being added temporariliy be an issue?

mhdawson commented 11 months ago

PR to avoid addition of receipts.sh https://github.com/paketo-community/ubi-base-stack/pull/15

mhdawson commented 11 months ago

I think this PR needs to land for https://github.com/paketo-community/ubi-base-stack/pull/15 to pass CI.

sophiewigmore commented 11 months ago

@mhdawson added those changes here

pacostas commented 11 months ago

The Acceptance tests probably fails due to service was unavailable at that moment ERROR: failed to create builder: fetch build image: Error response from daemon: Head "https://registry-1.docker.io/v2/library/stack-build-6710dc2e-f2c0-42df-b1e8-2f91d64283c1/manifests/latest": received unexpected HTTP status: 503 Service Unavailable I tested all the branches locally in my pc and everything seems to work fine.