Closed pacostas closed 10 months ago
I'll take a look tomorrow!
In case people wonder about the reason for this.
1) our images are based on an existing image that used 1001 as the run image 2) when we originally tested out the nodejs-extension we used 1001 for both the build and run uids. During review it was suggested we be consistent with the rest of the buildpacks and use different uids. We did not know of any issue in doing that so modified to do that. 3) While @pacostas was running the existing integration tests againt the npm-install buildpack he discoverd a problem with permissions. 4) Swapping these uids in the way this PR does maintains the separation of using a different uid in the build and run phases while keeping the run uid consistent with what is used in the base images we are extending and resolves the permissions issues we ran into.
@pacostas changes look good, just need an update to the integration tests here because they are now failing
Summary
The purpose of this PR is to set proper
uids
andgids
on stack images.Use Cases
Checklist