Adding UBI-8 JDK-21 image

paketo-community / ubi-base-stack

Apache License 2.0

2 stars 5 forks source link

Closed matzew closed 6 months ago

matzew commented 7 months ago

Adding JDK-21 ubi image (see #40)

New LTS version of java is 21, and we do not yet have that in this repo

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

pacostas commented 7 months ago

LGTM

pacostas commented 7 months ago

@sophiewigmore Can you LGTM ?

matzew commented 7 months ago

@pacostas thanks for the comments, I have committed the suggestions, and added the bits to the gitignore file

matzew commented 7 months ago

@sophiewigmore thanks for approving the PR. Do you think we can merge the PR?

Once merged / image published, I will update the ubi-java-extension repo for leveraging this work here.

pacostas commented 6 months ago

@mhdawson this is the next one we need to merge . Also after merging can you close this issue https://github.com/paketo-community/ubi-base-stack/issues/40 ?

matzew commented 6 months ago

@sophiewigmore Hello! Is there anything missing on this PR, or do you think it can be merged ?

Thanks!