paketo-community / ubi-base-stack

Apache License 2.0
2 stars 5 forks source link

Reducing duplicate code on push-image github workflow #43

Closed pacostas closed 4 months ago

pacostas commented 5 months ago

Summary

This PR applies on push-image workflow:

Use Cases

Checklist

pacostas commented 5 months ago

The acceptance test failed probably due to the network

pacostas commented 4 months ago

@mhdawson Rebased, resolved the conflicts and commented out the code which pushes to gcr. Is ready for review.

mhdawson commented 4 months ago

@pacostas sorry, accidentally used the merge option to rebase which I did not want. To try to fix I pulled your fork, removed the merge commit and force pushed, which I thought would get me back to the point before I did that. Unfortunately it seems to removed your changes and closed the PR.

I still have a local branch with all of your changes on it, but what probably makes sense is for you to repush your local copy of the branch and re-open the PR, or possibly open an new PR if that is not possble.