paketo-community / ubi-base-stack

Apache License 2.0
2 stars 5 forks source link

Failures to run acceptance tests/publishing when creating a release #46

Closed mhdawson closed 4 months ago

mhdawson commented 4 months ago

Failure here - https://github.com/paketo-community/ubi-base-stack/actions/runs/8070665351/job/22053877535

strange since the tests ran/passed when run on the PR itself.

@pacostas can you take a look?

pacostas commented 4 months ago

Yeap, opened PR https://github.com/paketo-community/ubi-base-stack/pull/50 . what was happening, is that the acceptance tests were trying to use a build image that hasnt been downloaded by the workflow. https://github.com/paketo-community/ubi-base-stack/blob/16cf3741c1c642eb6307845ad26891303da1cf9e/.github/workflows/create-release.yml#L551-L606

As you can see on the workflow we only download the one under the build directory and the tests for each node version were fetching the build-nodejs-xx/build.oci instead of the build/build.oci

mhdawson commented 4 months ago

The acceptance tests pass, but now we fail to upload

X-Xss-Protection: 1; mode=block
{"message":"Validation Failed","request_id":"F080:21909:16425F:1D811D:65E11279","documentation_url":"https://docs.github.com/rest","errors":[{"resource":"ReleaseAsset","code":"already_exists","field":"name"}]}
Retrying in 16.842089869s
  Uploading asset: build-java-21/run.oci -> ubi-base-stack-0.0.37-run-java-21.oci
Error: failed to upload asset: unexpected response: HTTP/2.0 422 Unprocessable Entity

@pacostas any chance this has to do with what we had to change to get the acceptance tests passing in the create release process? If not I'll take a closer look tomorrow.

pacostas commented 4 months ago

interesting because i didnt change anything on the create and push release except the upgrade of the actions. Im taking a look

pacostas commented 4 months ago

It was uploading twice the 21 java image and therefore the name was already exist. Opened PR https://github.com/paketo-community/ubi-base-stack/pull/52 with the fix. It is also tested.

mhdawson commented 4 months ago

@pacostas thanks, closing as should be resolved now.