search

paketo-community / ubi-base-stack

Apache License 2.0
2 stars 6 forks source link

Include images.json file in base image #88

Closed mhdawson closed 3 weeks ago

mhdawson commented 3 months ago

We should copy images.json it into '/etc/buildpacks/images.json'.

It should be owned by root, and the permissions be set to 744.

The plan is to use it in the extensions to find the run images instead of data into the extension.toml

cmoulliard commented 1 month ago

It should be owned by root, and the permissions be set to 744.

Why owned by root and why 744 as the file should not be executable ?

pacostas commented 3 weeks ago

Just a little bit of context, we dont execute the file, we only read its content.

cmoulliard commented 3 weeks ago

Just a little bit of context, we dont execute the file, we only read its content.

So then permissions should be 644 and not 744 !

pacostas commented 3 weeks ago

I see, thank you :) I'll test and open PR

mhdawson commented 3 weeks ago

Agree that 644 makes more sense, @pacostas thanks for taking care of that.

mhdawson commented 3 weeks ago

PR is ready and should land this week so closine.