Argument 1 passed to PsrHttpFactory::createRequest() must be an instance of Request, null given

[nelson6e65]

Hi. IDK if put this here or in paknahad/jsonapi-bundle, because this happens when using this extension.

I get this error (when authenticating using NelmioApiDocs or via Postman) when I use a custom Finder or paknahad/jsonapi-querifier-bundle:

[critical] Uncaught Error: Argument 1 passed to Symfony\Bridge\PsrHttpMessage\Factory\PsrHttpFactory::createRequest() must be an instance of Symfony\Component\HttpFoundation\Request, null given, called in ./vendor/paknahad/jsonapi-bundle/src/Factory/JsonApiFactory.php on line 45

When APP_DEBUG is set to true, this break the JSON response with the warning as plain text, so only works with APP_DEBUG=false.

Seems to be related with the requestStack, like an issue in https://github.com/AdactiveSAS/saml2-bridge-bundle/issues/28

https://github.com/paknahad/jsonapi-bundle/blob/98c75e1337f9043aeafcd3dbf032243b7d59abbf/src/Factory/JsonApiFactory.php#L41-L46

https://github.com/AdactiveSAS/saml2-bridge-bundle/blob/a517b096de30416a53d5f7dc3f24a6947e743e2b/src/Entity/HostedEntities.php#L141

Maybe my config is wrong?

My services.yaml config is:

services:
  paknahad_json_api.helper_filter.finder:
    class: Paknahad\JsonApiQuerifierBundle\Finder\Querifier
    public: false
    tags:
      - { name: paknahad.json_api.finder }

Am I missing something?

[nelson6e65]

error.html

```html

Symfony Exception

Symfony Docs

TypeError

HTTP 500 Internal Server Error

Argument 1 passed to Symfony\Bridge\PsrHttpMessage\Factory\PsrHttpFactory::createRequest() must be an instance of Symfony\Component\HttpFoundation\Request, null given, called in /var/www/app/vendor/paknahad/jsonapi-bundle/src/Factory/JsonApiFactory.php on line 44

Exception

TypeError

in /var/www/app/vendor/symfony/psr-http-message-bridge/Factory/PsrHttpFactory.php (line 49)

44.     }
46.     /**
47.      * {@inheritdoc}
48.      */
49.     public function createRequest(Request $symfonyRequest)
50.     {
51.         $uri = $symfonyRequest->server->get('QUERY_STRING', '');
52.         $uri = $symfonyRequest->getSchemeAndHttpHost().$symfonyRequest->getBaseUrl().$symfonyRequest->getPathInfo().('' !== $uri ? '?'.$uri : '');
54.         $request = $this->serverRequestFactory->createServerRequest(

in /var/www/app/vendor/paknahad/jsonapi-bundle/src/Factory/JsonApiFactory.php -> createRequest (line 44)

39.     }
41.     public function create(): JsonApi
42.     {
43.         $jsonApiRequest = new JsonApiRequest(
44.             $this->psrFactory->createRequest($this->requestStack->getCurrentRequest()),
45.             $this->exceptionFactory
46.         );
48.         return new JsonApi($jsonApiRequest, $this->psrFactory->createResponse(new Response()), $this->exceptionFactory, $this->serializer);
49.     }

in /var/www/app/var/cache/dev/ContainerZrIxhJE/getJsonApiService.php -> create (line 27)

22.         include_once \dirname(__DIR__, 4).'/vendor/woohoolabs/yin/src/JsonApi/Exception/ExceptionFactoryInterface.php';
23.         include_once \dirname(__DIR__, 4).'/vendor/woohoolabs/yin/src/JsonApi/Exception/DefaultExceptionFactory.php';
24.         include_once \dirname(__DIR__, 4).'/vendor/woohoolabs/yin/src/JsonApi/Serializer/SerializerInterface.php';
25.         include_once \dirname(__DIR__, 4).'/vendor/woohoolabs/yin/src/JsonApi/Serializer/JsonSerializer.php';
27.         return $container->privates['WoohooLabs\\Yin\\JsonApi\\JsonApi'] = (new \Paknahad\JsonApiBundle\Factory\JsonApiFactory(($container->privates['Symfony\\Bridge\\PsrHttpMessage\\Factory\\PsrHttpFactory'] ?? $container->load('getPsrHttpFactoryService')), ($container->services['request_stack'] ?? ($container->services['request_stack'] = new \Symfony\Component\HttpFoundation\RequestStack())), new \WoohooLabs\Yin\JsonApi\Exception\DefaultExceptionFactory(), new \WoohooLabs\Yin\JsonApi\Serializer\JsonSerializer()))->create();
28.     }
29. }

in /var/www/app/var/cache/dev/ContainerZrIxhJE/App_KernelDevDebugContainer.php :: do (line 477)

472.     }
474.     protected function load($file, $lazyLoad = true)
475.     {
476.         if (class_exists($class = __NAMESPACE__.'\\'.$file, false)) {
477.             return $class::do($this, $lazyLoad);
478.         }
480.         if ('.' === $file[-4]) {
481.             $class = substr($class, 0, -4);
482.         } else {

in /var/www/app/var/cache/dev/ContainerZrIxhJE/getJsonApiErrorHandlerEventService.php -> load (line 25)

20.         include_once \dirname(__DIR__, 4).'/vendor/paknahad/jsonapi-bundle/src/EventSubscriber/JsonApiErrorHandlerEvent.php';
21.         include_once \dirname(__DIR__, 4).'/src/Utils/JsonApi/Events/JsonApiErrorHandlerEvent.php';
22.         include_once \dirname(__DIR__, 4).'/vendor/symfony/psr-http-message-bridge/HttpFoundationFactoryInterface.php';
23.         include_once \dirname(__DIR__, 4).'/vendor/symfony/psr-http-message-bridge/Factory/HttpFoundationFactory.php';
25.         return $container->privates['App\\Utils\\JsonApi\\Events\\JsonApiErrorHandlerEvent'] = new \App\Utils\JsonApi\Events\JsonApiErrorHandlerEvent('dev', true, ($container->privates['WoohooLabs\\Yin\\JsonApi\\JsonApi'] ?? $container->load('getJsonApiService')), ($container->privates['sensio_framework_extra.psr7.http_foundation_factory'] ?? ($container->privates['sensio_framework_extra.psr7.http_foundation_factory'] = new \Symfony\Bridge\PsrHttpMessage\Factory\HttpFoundationFactory())));
26.     }
27. }

in /var/www/app/var/cache/dev/ContainerZrIxhJE/App_KernelDevDebugContainer.php :: do (line 477)

472.     }
474.     protected function load($file, $lazyLoad = true)
475.     {
476.         if (class_exists($class = __NAMESPACE__.'\\'.$file, false)) {
477.             return $class::do($this, $lazyLoad);
478.         }
480.         if ('.' === $file[-4]) {
481.             $class = substr($class, 0, -4);
482.         } else {

in /var/www/app/var/cache/dev/ContainerZrIxhJE/App_KernelDevDebugContainer.php -> load (line 894)

889.         }, 1 => 'onKernelResponse'], 0);
890.         $instance->addListener('kernel.response', [0 => function () {
891.             return ($this->privates['nelmio_cors.cacheable_response_vary_listener'] ?? ($this->privates['nelmio_cors.cacheable_response_vary_listener'] = new \Nelmio\CorsBundle\EventListener\CacheableResponseVaryListener()));
892.         }, 1 => 'onResponse'], 0);
893.         $instance->addListener('kernel.exception', [0 => function () {
894.             return ($this->privates['App\\Utils\\JsonApi\\Events\\JsonApiErrorHandlerEvent'] ?? $this->load('getJsonApiErrorHandlerEventService'));
895.         }, 1 => 'onKernelException'], 0);
896.         $instance->addListener('kernel.exception', [0 => function () {
897.             return ($this->privates['jsonapi.error.handler.event'] ?? $this->load('getJsonapi_Error_Handler_EventService'));
898.         }, 1 => 'onKernelException'], 0);
899.         $instance->addListener('kernel.response', [0 => function () {

in /var/www/app/vendor/symfony/event-dispatcher/EventDispatcher.php -> ContainerZrIxhJE\{closure} (line 267)

262.             foreach ($listeners as &$listener) {
263.                 $closure = &$this->optimized[$eventName][];
264.                 if (\is_array($listener) && isset($listener[0]) && $listener[0] instanceof \Closure && 2 >= \count($listener)) {
265.                     $closure = static function (...$args) use (&$listener, &$closure) {
266.                         if ($listener[0] instanceof \Closure) {
267.                             $listener[0] = $listener[0]();
268.                             $listener[1] = $listener[1] ?? '__invoke';
269.                         }
270.                         ($closure = \Closure::fromCallable($listener))(...$args);
271.                     };
272.                 } else {

in /var/www/app/vendor/symfony/event-dispatcher/EventDispatcher.php :: Symfony\Component\EventDispatcher\{closure} (line 230)

226.         foreach ($listeners as $listener) {
227.             if ($stoppable && $event->isPropagationStopped()) {
228.                 break;
229.             }
230.             $listener($event, $eventName, $this);
231.         }
232.     }
234.     /**
235.      * Sorts the internal list of listeners for the given event by priority.

in /var/www/app/vendor/symfony/event-dispatcher/EventDispatcher.php -> callListeners (line 59)

54.         } else {
55.             $listeners = $this->getListeners($eventName);
56.         }
58.         if ($listeners) {
59.             $this->callListeners($listeners, $eventName, $event);
60.         }
62.         return $event;
63.     }

in /var/www/app/vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php -> dispatch (line 154)

149.         try {
150.             $this->beforeDispatch($eventName, $event);
151.             try {
152.                 $e = $this->stopwatch->start($eventName, 'section');
153.                 try {
154.                     $this->dispatcher->dispatch($event, $eventName);
155.                 } finally {
156.                     if ($e->isStarted()) {
157.                         $e->stop();
158.                     }
159.                 }

in /var/www/app/vendor/symfony/http-kernel/HttpKernel.php -> dispatch (line 213)

208.      * @throws \Exception
209.      */
210.     private function handleThrowable(\Throwable $e, Request $request, int $type): Response
211.     {
212.         $event = new ExceptionEvent($this, $request, $type, $e);
213.         $this->dispatcher->dispatch($event, KernelEvents::EXCEPTION);
215.         // a listener might have replaced the exception
216.         $e = $event->getThrowable();
218.         if (!$event->hasResponse()) {

in /var/www/app/vendor/symfony/http-kernel/HttpKernel.php -> handleThrowable (line 106)

101.     {
102.         if (!$request = $request ?: $this->requestStack->getMainRequest()) {
103.             throw $exception;
104.         }
106.         $response = $this->handleThrowable($exception, $request, self::MAIN_REQUEST);
108.         $response->sendHeaders();
109.         $response->sendContent();
111.         $this->terminate($request, $response);

in /var/www/app/vendor/symfony/http-kernel/EventListener/DebugHandlersListener.php -> terminateWithException (line 131)

126.                         if ($hasRun) {
127.                             throw $e;
128.                         }
130.                         $hasRun = true;
131.                         $kernel->terminateWithException($e, $request);
132.                     };
133.                 }
134.             } elseif ($event instanceof ConsoleEvent && $app = $event->getCommand()->getApplication()) {
135.                 $output = $event->getOutput();
136.                 if ($output instanceof ConsoleOutputInterface) {

in /var/www/app/vendor/symfony/error-handler/ErrorHandler.php :: Symfony\Component\HttpKernel\EventListener\{closure} (line 607)

602.             $this->exceptionHandler = null;
603.         }
605.         try {
606.             if (null !== $exceptionHandler) {
607.                 return $exceptionHandler($exception);
608.             }
609.             $handlerException = $handlerException ?: $exception;
610.         } catch (\Throwable $handlerException) {
611.         }
612.         if ($exception === $handlerException && null === $this->exceptionHandler) {

ErrorHandler->handleException(object(TypeError))

Stack Trace

TypeError

TypeError: Argument 1 passed to Symfony\Bridge\PsrHttpMessage\Factory\PsrHttpFactory::createRequest() must be an instance of Symfony\Component\HttpFoundation\Request, null given, called in /var/www/app/vendor/paknahad/jsonapi-bundle/src/Factory/JsonApiFactory.php on line 44 at /var/www/app/vendor/symfony/psr-http-message-bridge/Factory/PsrHttpFactory.php:49 at Symfony\Bridge\PsrHttpMessage\Factory\PsrHttpFactory->createRequest(null) (/var/www/app/vendor/paknahad/jsonapi-bundle/src/Factory/JsonApiFactory.php:44) at Paknahad\JsonApiBundle\Factory\JsonApiFactory->create() (/var/www/app/var/cache/dev/ContainerZrIxhJE/getJsonApiService.php:27) at ContainerZrIxhJE\getJsonApiService::do(object(App_KernelDevDebugContainer), true) (/var/www/app/var/cache/dev/ContainerZrIxhJE/App_KernelDevDebugContainer.php:477) at ContainerZrIxhJE\App_KernelDevDebugContainer->load('getJsonApiService') (/var/www/app/var/cache/dev/ContainerZrIxhJE/getJsonApiErrorHandlerEventService.php:25) at ContainerZrIxhJE\getJsonApiErrorHandlerEventService::do(object(App_KernelDevDebugContainer), true) (/var/www/app/var/cache/dev/ContainerZrIxhJE/App_KernelDevDebugContainer.php:477) at ContainerZrIxhJE\App_KernelDevDebugContainer->load('getJsonApiErrorHandlerEventService') (/var/www/app/var/cache/dev/ContainerZrIxhJE/App_KernelDevDebugContainer.php:894) at ContainerZrIxhJE\App_KernelDevDebugContainer->ContainerZrIxhJE\{closure}() (/var/www/app/vendor/symfony/event-dispatcher/EventDispatcher.php:267) at Symfony\Component\EventDispatcher\EventDispatcher::Symfony\Component\EventDispatcher\{closure}(object(ExceptionEvent), 'kernel.exception', object(EventDispatcher)) (/var/www/app/vendor/symfony/event-dispatcher/EventDispatcher.php:230) at Symfony\Component\EventDispatcher\EventDispatcher->callListeners(array(object(Closure), object(Closure), object(Closure), object(Closure), object(Closure), object(Closure)), 'kernel.exception', object(ExceptionEvent)) (/var/www/app/vendor/symfony/event-dispatcher/EventDispatcher.php:59) at Symfony\Component\EventDispatcher\EventDispatcher->dispatch(object(ExceptionEvent), 'kernel.exception') (/var/www/app/vendor/symfony/event-dispatcher/Debug/TraceableEventDispatcher.php:154) at Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->dispatch(object(ExceptionEvent), 'kernel.exception') (/var/www/app/vendor/symfony/http-kernel/HttpKernel.php:213) at Symfony\Component\HttpKernel\HttpKernel->handleThrowable(object(TypeError), object(Request), 1) (/var/www/app/vendor/symfony/http-kernel/HttpKernel.php:106) at Symfony\Component\HttpKernel\HttpKernel->terminateWithException(object(TypeError), object(Request)) (/var/www/app/vendor/symfony/http-kernel/EventListener/DebugHandlersListener.php:131) at Symfony\Component\HttpKernel\EventListener\DebugHandlersListener::Symfony\Component\HttpKernel\EventListener\{closure}(object(TypeError)) (/var/www/app/vendor/symfony/error-handler/ErrorHandler.php:607) at Symfony\Component\ErrorHandler\ErrorHandler->handleException(object(TypeError))

```