search

pal-robotics / aruco_ros

Software package and ROS wrappers of the Aruco Augmented Reality marker detector library
MIT License
470 stars 312 forks source link

[Humble] Failing to build on buildfarm because of ambiguity #118

Closed audrow closed 1 year ago

audrow commented 1 year ago

It seems that their is ambiguity about which overload is being called for the subscribe function.

You can see this in the buildfarm here: https://build.ros2.org/view/Hbin_uJ64/job/Hbin_uJ64__aruco_ros__ubuntu_jammy_amd64__binary/21/console

Maybe this has to do with the last patch release, which happened around the time this job started failing.

saikishor commented 1 year ago

Hello @audrow,

Yes, we noticed it a few days back. We couldn't address it as most of the team is on vacation. I will try to fix it during these days. Thanks for the heads-up anyway.

Thank you,

Best Regards, Sai

saikishor commented 1 year ago

It seems that their is ambiguity about which overload is being called for the subscribe function.

Hello @audrow!

I've taken a quick look, it seems like this PR has broken most of it's downstream packages and thereby causing ambiguity: https://github.com/ros-perception/image_common/pull/276.

I'll see what I can do.

Thank you,

Best Regards, PAL Robotics Team

saikishor commented 1 year ago

Hello @audrow !

The fix for the humble branch is merged : https://github.com/ros-perception/image_common/pull/284. Once this is tagged and released, this should sort out the issue with the broken build.

Thank you,

Best Regards, PAL Robotics Team

saikishor commented 1 year ago

Hello @audrow,

The package of image_transport is now released to upstream and it seems like it already fixed the CI: https://build.ros2.org/job/Hbin_uJ64__aruco_ros__ubuntu_jammy_amd64__binary/29/. Closing the issue as it is already fixed.

Thank you for your patience,

Best Regards, PAL Robotics Team.