search

pal-robotics / aruco_ros

Software package and ROS wrappers of the Aruco Augmented Reality marker detector library
MIT License
449 stars 307 forks source link

Marker pixel info #30

Closed JakeBrawer closed 7 years ago

JakeBrawer commented 7 years ago

The Marker msg type now contains data relating to pixel coordinates of a marker's corners and center.

jdlangs commented 7 years ago

There doesn't seem to be any way to deduce the added message fields are in pixels without reading the code. Ideally, it should be obvious from the names of the fields themselves.

jdlangs commented 7 years ago

Also, am I just missing something or does the new center message field never get populated?

bmagyar commented 7 years ago

Thanks @jdlangs for the extra notes, the center could be removed as it's trivial to compute it from the corners.

JakeBrawer commented 7 years ago

Hello all, thank you for your timely and trenchant comments. I actually meant to open this pull request on our own fork of this repo, but obviously failed to do so as I am a noob apparently :^). Do you think you can terminate this PR (or tell me how to do it!). Unless you find any of these changes useful, in which case I'll make the changes.

Thanks again, and sorry for the confusion.