pal-robotics / aruco_ros

Software package and ROS wrappers of the Aruco Augmented Reality marker detector library
MIT License
449 stars 307 forks source link

Change default threshold to match defaults of aruco marker detector #32

Closed v-lopez closed 7 years ago

v-lopez commented 7 years ago

Changed default threshold parameters to match aruco's markerdetector defaults.

This is motivated by https://github.com/pal-robotics/aruco_ros/pull/31 because the behaviour will change, it will go from using 7 and 7, to 4 and 8 set by the dynamic reconfigure.

And also a few experiments here: Debugging with the current parameters (4,8):

aruco_4_8

Debugging with marker detector default parameters (7,7) proposed by this MR: aruco_7_7

bmagyar commented 7 years ago

:+1: