Upgrade core aruco library to v1.2.5 + Map coordinates into ROS

pal-robotics / aruco_ros

Software package and ROS wrappers of the Aruco Augmented Reality marker detector library

MIT License

449 stars 307 forks source link

Upgrade core aruco library to v1.2.5 + Map coordinates into ROS #4

Closed ghost closed 10 years ago

ghost commented 10 years ago

Upgrade core aruco library to v1.2.5; will not harm, and might help in the near future...
Map ArUco coordinates into ROS; OpenCV uses a weird orientation, this fix would make things straight.

bmagyar commented 10 years ago

Do you need 1.2.5 of Aruco to use with your additions?

ghost commented 10 years ago

Currently no! But I plan to use it in the near future. Besides it will not harm to upgrade, would it?

ghost commented 10 years ago

The trouble with the world is that the stupid are cocksure and the intelligent are full of doubt. Ironically, no good is ever done in this world by hesitation.

Never mind then! I got tired of waiting ...

jordi-pages commented 10 years ago

@Sahloul, @bmagyar

Dear Hamdi, I'd like you to reconsider re-opening the pull request. If it takes time to get accepted is because aruco_ros is being used in our commercial robots and, potentially, in other robots. Furthermore, as professionals roboticists, we have plenty of work to do apart from the important task of taking care of community contributions, which, let me remark it, are all very wellcome.

If you take a look at other ROS packages maintained by compines or public institutions you will see that pull requests undergo code reviews, style polishing, etc. to fit a given set of Quality Assurement requirements in line with modern programming strategies and software life cycle maintenance.

In summary, it won't take ages that a pull requests gets accepted, just let us do it properly in benefit of all us.

Best regards

Jordi

ghost commented 10 years ago

I also do a lot of testing, as I am aware how critical such changes might effect the system, but I never expected such delays. To be honest, I was planing to push a lot of changes, and I started worrying that I will not be done with this for months this way! Nonetheless, opening this request once again will not harm, but I wonder if this will ever work after I already deleted my repository permanently!

davetcoleman commented 10 years ago

I don't know much about this project, but I'll second @jordi-pages 's sentiments about these things taking a while. With the MoveIt! project, pull requests take several weeks on average. Patience is important.