search

pal-robotics / aruco_ros

Software package and ROS wrappers of the Aruco Augmented Reality marker detector library
MIT License
448 stars 306 forks source link

Aruco 3.0.4 #44

Open v-lopez opened 6 years ago

v-lopez commented 6 years ago

@bmagyar Any feelings about this?

bmagyar commented 6 years ago

A code change of this magnitude cannot be reviewed in the usual way. If performance and detection rates are still ok then we should be generally fine.

There's one thing I've spotted though: the optimal markers tool seems to be gone. What's the recommended way to generate new (sets of) markers now?

v-lopez commented 6 years ago

@bmagyar I haven't been able to find a substitute for the selectoptimal markers tool in the latest aruco version.

v-lopez commented 4 years ago

@bmagyar I'm working on some more major changes on top of this. At this point I'm torn between setting this branch as melodic-devel, putting all in a fork and leave this intact, or making an aruco3_ros package or something, starting from this.

I want to make quite a bit of backward incompatible changes in the launch files that are due from long time ago, like allowing full topic names as input of launch files, instead of "side", removing hard coded frames.. Also restructuring the code and making some functions reusable from outside the nodes in a library.

What are your thoughts?

bmagyar commented 4 years ago

"Let the past die, kill it, if you have to."

Don't make a new package with a version in the name, those are always confusing.

On Tue, 21 Jan 2020, 11:52 Victor Lopez, notifications@github.com wrote:

@bmagyar https://github.com/bmagyar I'm working on some more major changes on top of this. At this point I'm torn between setting this branch as melodic-devel, putting all in a fork and leave this intact, or making an aruco3_ros package or something, starting from this.

I want to make quite a bit of backward incompatible changes in the launch files that are due from long time ago, like allowing full topic names as input of launch files, instead of "side", removing hard coded frames.. Also restructuring the code and making some functions reusable from outside the nodes in a library.

What are your thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pal-robotics/aruco_ros/pull/44?email_source=notifications&email_token=AA24PYJUQOMOR4XZT3DPRTLQ63OZFA5CNFSM4EPSIJM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJPPGKQ#issuecomment-576647978, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA24PYI3YNG6PLTZCLFOCALQ63OZFANCNFSM4EPSIJMQ .