No version for Noetic OpenCV4

pal-robotics / aruco_ros

Software package and ROS wrappers of the Aruco Augmented Reality marker detector library

MIT License

455 stars 309 forks source link

No version for Noetic OpenCV4 #89

Closed RDaneelOlivav closed 3 years ago

RDaneelOlivav commented 3 years ago

Hi,

Trying to compile for noetic OpenCV 4 but its crashing everywhere. An plan for a Noetic release? Thanks

v-lopez commented 3 years ago

Not immediately, we may even invest time on ROS2 before noetic (which will have also OpenCV4, but will change a lot more code), but if anyone can submit a PR for noetic we'll take a look.

felixvd commented 3 years ago

@4lhc Is there a reason you didn't make a PR for that branch? It compiled on Noetic for me.

4lhc commented 3 years ago

@felixvd I didn't make a PR because there was an issue with the marker pose that I noticed, the cause of which I was not sure of. The marker pose was always at an offset from the real position of the marker as seen in the attached image. I didn't get time to explore it further.

OTL commented 3 years ago

@4lhc I've checked your code on noetic, and it seems that it works perfectly for me. Screenshot from 2021-05-20 15-48-40

lucamarchionna commented 3 years ago

Hi everyone, I was trying to use this repository on Noetic but I'm having problems when compiling this package, due to the wrong version of OpenCV. Snce you solved the problem, how can I fix this issue? Thanks in advance.

OTL commented 3 years ago

I think https://github.com/4lhc/aruco_ros just works fine.

v-lopez commented 3 years ago

@4lhc feel free to make a PR and if the issue you mention is verified we can fix it.

Actually not a PR since we won't merge to main branch, but with your permission I'll push your commit to a new noetic-devel branch.

4lhc commented 3 years ago

@v-lopez Sure, go ahead.

v-lopez commented 3 years ago

Done!