search

pal-robotics / backward_ros

MIT License
188 stars 25 forks source link

Fix name mismatch warnings #11

Closed vatanaksoytezer closed 2 years ago

vatanaksoytezer commented 2 years ago

We are happily using backward_ros on MoveIt. Since the transition of Rolling to Jammy (thus to default cmake to be updated to 3.22), we are getting a flood of warnings related to FindPackageHandleStandardArgs every time we find package to backward_ros. This should hopefully fix it. We would be more than delighted for a new release of backward_ros on Rolling, so we don't have this flood.

Hope this makes sense. The fix was inspired from the same problem in catkin, here.

You can find a sample warning below:

CMake Warning (dev) at /usr/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (libbfd)
  does not match the name of the calling package (backward_ros).  This can
  lead to problems in calling code that expects `find_package` result
  variables (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  /opt/ros/rolling/share/backward_ros/cmake/BackwardConfig.cmake:66 (find_package_handle_standard_args)
  /opt/ros/rolling/share/backward_ros/cmake/backward_rosConfig.cmake:41 (include)
  /root/ws_moveit2/install/moveit_common/share/moveit_common/cmake/moveit_package.cmake:36 (find_package)
  CMakeLists.txt:6 (moveit_package)
This warning is for project developers.  Use -Wno-dev to suppress it.
vatanaksoytezer commented 2 years ago

Friendly ping to @v-lopez, to see if this makes sense.

v-lopez commented 2 years ago

LGTM, but I am no longer working at PAL Robotics, pinging @jordan-palacios.

vatanaksoytezer commented 2 years ago

Another friendly ping to @jordan-palacios, to see if we can merge this and get a rolling release so we (and any package using this on rolling) is free of warnings.

jordan-palacios commented 2 years ago

Thanks for the collaboration. And sorry for the delay.

We'll try to release this ASAP.

vatanaksoytezer commented 2 years ago

Thanks a lot Jordan, we appreciate all the help!

saikishor commented 2 years ago

Hello @vatanaksoytezer,

We have requested for the release in the rolling distro. FYI: https://github.com/ros/rosdistro/pull/32613

Best Regards, PAL Robotics Team.

vatanaksoytezer commented 2 years ago

@saikishor we appreciate the effort and the fast action, thank you very much!

saikishor commented 2 years ago

Hello @vatanaksoytezer,

The package is already merged to rosdistro upstream : https://github.com/ros/rosdistro/pull/32647

Thank you.