search

pal-robotics / ddynamic_reconfigure

89 stars 76 forks source link

support for `float` type #2

Closed naveedhd closed 5 years ago

naveedhd commented 5 years ago

Hi,

I have a use case where a 3rd party library has float inputs, that I want to reconfigure in my code.

right now I am resorting to double and implicit conversions but would it be good to have instantiations for float also?

v-lopez commented 5 years ago

The dynamic_reconfigure API which this is based on (from ROS) only supports int, bool, double, string and enums: http://docs.ros.org/melodic/api/dynamic_reconfigure/html/index-msg.html

Internally we'd end up converting the float to double anyway, so I believe it would be confusing to support it externally but convert it internally.

naveedhd commented 5 years ago

ah makes sense! thanks!