search

pal-robotics / ddynamic_reconfigure

89 stars 76 forks source link

ROS_INFO on parameter change #22

Open Timple opened 3 years ago

Timple commented 3 years ago

We use the callback function often only to print a ROS_INFO statement. This is mostly helpful in analysing bagfiles afterwards. It would be nice if it was possible to enable a ROS_INFO statement for every parameter change.

Would you be interested in a feature like this?

v-lopez commented 3 years ago

It might be interesting, but it should be ABI compatible.

I don't know if there's a reasonable way of doing it without adding members to the class to store that flag that determines whether to print or not.

This is a core package for us, and abi breaks are very painful.

An alternative solution would be to add a ROS_DEBUG macro could be enabled if you wanted this info by modifying it's logger.

Timple commented 3 years ago

Could it be done by adding a function that does the ROS_INFO print? That way we can simply refer to that one for the callback argument.

v-lopez commented 3 years ago

Just add the function there for convenience and if someone wants to use it they just pass it as the callback argument? Sounds good to me

Timple commented 3 years ago

This issue is a little bit on hold because I'm unfamiliar with ABI compatibility.

Would a ABI break for the noetic release be feasible? Perhaps you're not on that release yet.