pal-robotics / realsense_gazebo_plugin

167 stars 140 forks source link

Fix gazebo_ros:plugin_path in package.xml #2

Open peci1 opened 4 years ago

peci1 commented 4 years ago

Using ${prefix}/lib is wrong.

According to the rospack implementation, ${prefix} is not context-dependent and get always expanded to the package path. If you're using devel space, this results in path to the package's source, not to the devel directory.

And really, this is from a DEBUG log of gazebo_ros.paths_plugin:

[DEBUG] [1575894134.676531222]: plugin path /opt/ros/cras_subt/src/realsense_gazebo_plugin/lib

The subexpression used in the PR works so that it asks catkin for the absolute path to the built library and takes the directory it resides in. This expression is evaluated at launch time, so we can be sure the library is already built at that time.