pal-robotics / reem_simulation

Packages for running REEM in the Gazebo simulator.
2 stars 9 forks source link

Added a launcher for the objects on table world with cans on it #3

Closed awesomebytes closed 10 years ago

po1 commented 10 years ago

@bmagyar can you try that on your desktop or your laptop?

bmagyar commented 10 years ago

I wouldn't populate the package with such launch files. roslaunch reem_gazebo reem_gazebo.launch world:=objects_on_table roslaunch reem_gazebo reem_objects_on_table.launch

I don't see much difference between those 2 comments but another file for being able to use the latter command is increasing clutter with not much benefits. That's my opinion.

awesomebytes commented 10 years ago

Maybe this launchfile should be in some application related package. Does that sound better? There will be a tutorial on how to grasp, so it can be added in the package of that tutorial.

2014/1/12 Bence Magyar notifications@github.com

I wouldn't populate the package with such launch files. roslaunch reem_gazebo reem_gazebo.launch world:=objects_on_table roslaunch reem_gazebo reem_objects_on_table.launch

I don't see much difference between those 2 comments but another file for being able to use the latter command is increasing clutter with not much benefits. That's my opinion.

— Reply to this email directly or view it on GitHubhttps://github.com/pal-robotics/reem_simulation/pull/3#issuecomment-32136313 .

jordi-pages commented 10 years ago

I wouldn't populate the package with such launch files. roslaunch reem_gazebo reem_gazebo.launch world:=objects_on_table roslaunch reem_gazebo reem_objects_on_table.launch

I don't see much difference between those 2 comments but another file for being able to use the latter command is increasing clutter with not much benefits. That's my opinion.

+1

I'd prefer to document how to launch the simulation in the corresponding tutorial rather than adding a new launch file

— Reply to this email directly or view it on GitHubhttps://github.com/pal-robotics/reem_simulation/pull/3#issuecomment-32136313 .

Jordi Pages, PhD Computer Vision

jordi.pages@pal-robotics.com www.pal-robotics.com

[image: cid:image003.png@01CAC1D4.21F0FEF0]

Pal Robotics, S.L. c/ Pujades 77-79, 4º1ª 08005 Barcelona Spain Tel +34 93 414 53 47 Fax +34 93 209 11 09 Skype: jordi.pal-robotics

Facebook http://www.facebook.com/palrobotics1 - Twitterhttp://twitter.com/#%21/palrobotics- PAL Robotics YouTube Channel http://www.youtube.com/user/PALRobotics

P Antes de imprimir este e-mail piense bien si es necesario hacerlo: El medioambiente es cosa de todos.

AVISO DE CONFIDENCIALIDAD: Este mensaje y sus documentos adjuntos, pueden contener información privilegiada y/o confidencial que está dirigida exclusivamente a su destinatario. Si usted recibe este mensaje y no es el destinatario indicado, o el empleado encargado de su entrega a dicha persona, por favor, notifíquelo inmediatamente y remita el mensaje original a la dirección de correo electrónico indicada. Cualquier copia, uso o distribución no autorizados de esta comunicación queda estrictamente prohibida.

CONFIDENTIALITY NOTICE: This e-mail and the accompanying document(s) may contain confidential information which is privileged and intended only for the individual or entity to whom they are addressed. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or use of this e-mail and/or accompanying document(s) is strictly prohibited. If you have received this e-mail in error, please immediately notify the sender at the above e-mail address.

adolfo-rt commented 10 years ago

+1 to a separate package. We could either have a package with worlds specific to a use case, like grasping (e.g., a tutorial), or a package containing 'assorted worlds' that are frequently used by us. Either is fien for me, it mostly depends on the balance between too many packages vs. too much unrelated stuff in a single package.

bmagyar commented 10 years ago

I like the idea of Adolfo. In a separate package we could even collect launch files specific to functionalities that brings up everything, even the robot in a specific pose (head looking down at the table for obj recog for example).

One launch file to rule them all, One launch file to find them, One launch file to bring them all, And with ROS bind them.

po1 commented 10 years ago

The thing is, reem_gazebo doesn't do much right now. If you take out all the world files, the config params, there will be nothing left, and you will end up with pretty much a copy of the actual reem_gazebo, but with a different name...

bmagyar commented 10 years ago

This conversation is about reem_gazebo ;)

po1 commented 10 years ago

Don't know what you're talking about :grin:

po1 commented 10 years ago

Since a number of us don't see any interest in this new file, I'm closing the pull request. Please add further arguments in favor of re-opening it below.

bmagyar commented 10 years ago

There will be a package with a launch file and a tricky script that launches this world + sets up everything for tabletop perception&manipulation prepared by @awesomebytes .