search

pal-robotics / reemc_simulation

Packages for running REEM-C in the Gazebo simulator.
3 stars 4 forks source link

Version Incompatible with Gazebo 7 #3

Open sauronalexander opened 8 years ago

sauronalexander commented 8 years ago

I found several issues when compiling with gazebo 7. In Reemc_Harward_Gazebo, imu_sensor should be std::share_ptr, and should be std::dynamic_pointer_cast instead of boost::dynamic_pointer_cast. Also, there are some function name changes, such as Orientation and etc.

CMakeList should set CMAKE_CXX_FLAGS with -std=c++0x. Thanks.

awesomebytes commented 8 years ago

This package was updated 2 years ago for the last time, Gazebo 7 wasn't there at that point. I don't know if anyone at PAL is working on supporting Gazebo 7.

But if you find the fixes to make it work and provide a Pull Request I'm sure it will be appreciated.

bmagyar commented 8 years ago

To add to Sam's comment: Gazebo is changing API within major version numbers. As far as I remember REEM-C as most PAL software supports the Indigo version.

Any pull requests supporting higher versions of Gazebo such as 7 need to be put on a new branch as it'd break compatibility with Gazebo 2-4.

sauronalexander commented 8 years ago

Hi Sam, I am Alexander (the same guy did an intern during the summer). I am running simulation in Gazebo. I used to use Gazebo 2, but there is all kinds of error. By updating the gazebo packages, some error are eliminated. It seemed after changing some code in this package, it needs another API called gazebo-pkgs. I have tried lots of methods to work around all the errors. It seems working at this moment. Thanks.

v-lopez commented 8 years ago

Hi @sauronalexander, I would suggest addressing the issues you might have with gazebo 2, as it is the supported platform like @bmagyar and @awesomebytes said. Nevertheless if you want to use gazebo 7, feel free to create make this package compatible with Gazebo 7 in a new branch.

We might make it compatible in the future, but at the moment it's not a priority.