search

pal-robotics / tiago_robot

http://wiki.ros.org/Robots/TIAGo
Apache License 2.0
41 stars 36 forks source link

Fixed the play motion launch file #19

Closed gstavrinos closed 1 year ago

gstavrinos commented 1 year ago

Based on the new launch_pal robot_utils library.

gstavrinos commented 1 year ago

This patch is an extension to a (currently local) work I have done on porting play_motion to humble. Any guidelines on how to submit a PR to play_motion? (There is only a foxy-devel branch)

jordan-palacios commented 1 year ago

This patch is an extension to a (currently local) work I have done on porting play_motion to humble. Any guidelines on how to submit a PR to play_motion? (There is only a foxy-devel branch)

Hello @gstavrinos. We are in the process of porting play_motion to ROS2 ourselves. Though we have opted for rewriting it from scratch, so no PRs regarding ROS2 will be accepted. In fact, we have pushed the first public version recently. The name of the project is play_motion2 and you can find it here. Mind that it's still a work in progress.

We intend to make play_motion2 part of the tiago public simulation soon too. For that same reason the very file you are patching here will most likely be scraped or rewritten.

Thanks for the contribution anyways. :)

gstavrinos commented 1 year ago

Ah, thanks for the info Jordan. Bad timing, I guess! Since I need a working play_motion implementation, I will stick with my fork for now, and switch to play_motion2 when it's ready.

Have fun and good luck with you robots!