search

pal-robotics / tiago_robot

http://wiki.ros.org/Robots/TIAGo
Apache License 2.0
41 stars 36 forks source link

install DESTINATION / #6

Closed olivier-stasse closed 5 years ago

olivier-stasse commented 5 years ago

The following line https://github.com/pal-robotics/tiago_robot/blob/aab9e850a63b157122d1dbebddb6763e62ab0bf9/tiago_bringup/CMakeLists.txt#L15 is making a catkin_make install failing because it tries to access the root of the system.

In our packaging system this is also failing.

It is probably making sense on the real robot but for simulation, CI or local deployment this seems to be a problem.

Would it be ok to add a cmake variable to disable this install ? For you to have no change it would be set to a default value performing the install.

v-lopez commented 5 years ago

Hi @olivier-stasse, thanks for the fix suggestion.

We'll be moving this rule to a separate package, because it really doesn't belong here.

I'm pushing an update that fixes this: https://github.com/pal-robotics/tiago_robot/commit/702f87c3c0c42d018252584a96dcd8c50a8cd537

olivier-stasse commented 5 years ago

Fixed by 702f87c

olivier-stasse commented 5 years ago

Thanks for the release !