search

palaeoverse / rphylopic

Get Silhouettes of Organisms from PhyloPic
https://rphylopic.palaeoverse.org
GNU General Public License v3.0
91 stars 9 forks source link

add text argument #64

Closed LewisAJones closed 1 year ago

LewisAJones commented 1 year ago

This PR adds the text argument to get_attribution. This allows the user to return a text paragraph of the attribution information to insert directly into a figure caption or similar.

I am not particularly happy with the approach for getting the license information. I originally thought I could just pull this from the PhyloPic API but when testing this, it doesn’t seem to return all the different licenses. Therefore, this is hardcoded for now, but could be updated!

These updates also now allow get_attribution to be called with multiple uuids at once.

Closes #56.

LewisAJones commented 1 year ago

Hi @willgearty, I've implemented your suggestions! The combine_words function is a nice addition!

willgearty commented 1 year ago

Whoops, you forgot to move knitr from suggests to imports @LewisAJones!

willgearty commented 1 year ago

Fixed! I'll merge once the checks pass, thanks!