Closed ms609 closed 3 months ago
Amazing, thanks so much for these pointes @ms609. Will work on this very shortly, and tick off the items in your list as they are addressed. Where requried, I will respond in italics
@m609 - all the above points are now addressed bar one (see below) - I'll leave the comment open for a day or two in case you want to check any of the above out, and if I hear nothing further, then close it.
-- Are there alternatives to QT for users who do not
To an extent, yes. You do not need an account to use on an open source OS, so if those T&Cs are an issue, this would be the solution (although I recognise that may not be convenient). Long term, my intention is to replace all QT datastrctures and classes in the core simulation with STL C++, allowing me to compile a headless version for command line use (which relates to issue #31 ) - but that will be in a future release
Looks good to me! 👍🏾
As part of my JOSS review, I've attempted to compile TREvoSim 3 on Windows 10, following
https://trevosim.readthedocs.io/en/latest/requirements.htmlhttps://trevosim.readthedocs.io/en/latest/requirementsinstallation.htmlOverall my main impression is that the installation instructions assume that a user is already experienced in using GitHub and creating C++ binaries. My sense is that few users of the software will have this background, and that the documentation would be more useful if it assumed minimal programming experience, at a level that might be expected of a typical quantitatively-able graduate student in palaeontology/evolutionary biology.
Ease of navigating the documentation
Installation from binaries
README.md
; the link in "TREvoSim can be installed and installed/run from the binary releases on our [GitHub]https://github.com/palaeoware)." does not contain an obvious route to locating binaries.v1-3
syntax with a version number. Suggest using an en-dash – rather than a hyphen – or rewording, to make clear that this is a range.Installation from source
bin
folder? etc.