search

palaeoware / trevosim

TREvoSim - The [Tr]ee [Evo]lutionary [Sim]ulator program
GNU General Public License v3.0
5 stars 3 forks source link

Crash when not updating uninformative factor #40

Closed ms609 closed 6 months ago

ms609 commented 6 months ago

When I load these settings:

tax20_rate2.51.txt

(Uploaded as .txt because GitHub doesn't like the .xml file ending)

Then click "Batch" and select "No" in the "Hmmm" dialog

image

TREvoSim freezes.

If I select "Yes", it purrs away happily.

I see the same behaviour if I set the <stripUninformativeFactor> setting to a positive number whilst leaving stripUninformativeFactorSettings unset.

RussellGarwood commented 6 months ago

@ms609 - oof, good catch, this was a silly mistake. If you update the source to include the above commit, this will fix the crash. Based on one of your other comments (thanks!), I shall remove the calculate strip uninformative factor down the line, which will provide a more elegant solution than the last push (but I wanted to start fix this ASAP given it is a segfault).