Closed ms609 closed 4 weeks ago
This one is tricky, I'm afraid. The window priority issue was easily enough fixed, and I did so with the above push, and also changed the wording of the dialogue. I never got warning messages when it was running in parallel on Linux, so I can't test - but I think the above push should also fix lots of warnings when it is running in parallel.
I don't, however, get a reliable crash following the subsequent steps. I do get a sporadic crash when cancelling a batch, that can take a short while to occur after hitting cancel - this is something to do with how Qt and its parallelisation tools deal with the cancel, and I'm afraid debugging is not helping me tie it down as it's occurring within parallelised code after it should have terminated. I'd be interested if the above push fixes your predictable crash, and whether you also get this sporadic crash from cancelling a batch dialogue.
Looks like you've fixed the crash - running smoothly now!
[x] ! Warning window cannot be closed without first cancelling batch run, which I guess has a higher window priority
[x] Warning window says "hit run for" – not sure what this means – should this say "batch"?
Agree to continue. Batch begins to run – this is going to throw more warnings!
Allow second pass to begin for simulations that failed; let a few passes complete, then press cancel
Close the warning dialog
[x] ! Now click "Run". A short while into the run, TREvoSim closes.
I think this process described above is replicable. I've also seen the crash when pressing "run", then "batch - cancel - batch". I think the common factor is switching between "run" and "batch" modes.