palaeoware / trevosim

TREvoSim - The [Tr]ee [Evo]lutionary [Sim]ulator program
GNU General Public License v3.0
4 stars 3 forks source link

Crashes when run fails #45

Closed ms609 closed 4 weeks ago

ms609 commented 1 month ago

image

I think this process described above is replicable. I've also seen the crash when pressing "run", then "batch - cancel - batch". I think the common factor is switching between "run" and "batch" modes.

RussellGarwood commented 1 month ago

This one is tricky, I'm afraid. The window priority issue was easily enough fixed, and I did so with the above push, and also changed the wording of the dialogue. I never got warning messages when it was running in parallel on Linux, so I can't test - but I think the above push should also fix lots of warnings when it is running in parallel.

I don't, however, get a reliable crash following the subsequent steps. I do get a sporadic crash when cancelling a batch, that can take a short while to occur after hitting cancel - this is something to do with how Qt and its parallelisation tools deal with the cancel, and I'm afraid debugging is not helping me tie it down as it's occurring within parallelised code after it should have terminated. I'd be interested if the above push fixes your predictable crash, and whether you also get this sporadic crash from cancelling a batch dialogue.

ms609 commented 4 weeks ago

Looks like you've fixed the crash - running smoothly now!