palaniyappanBala / klish

Automatically exported from code.google.com/p/klish
Other
0 stars 0 forks source link

New Feature: Search in all subdiretories for xml files (Patch) #134

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
If you specify an xml directory /foo/bar.. only the top level files will be 
loaded.

With the attached patch all subdirectories within the given xml path(s) will be 
searched as well as symlinks to other directories.

Original issue reported on code.google.com by mark.s.m...@gmail.com on 8 Oct 2013 at 8:54

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks. But I'm not sure it's good. What the real profit?

Original comment by serj.kalichev@gmail.com on 9 Oct 2013 at 9:54

GoogleCodeExporter commented 8 years ago
Why wouldn't you want to load every file in the given directory?

It's required for me because I organize my xml into module directories, and add 
or remove symlinks depending on what xml needs to be loaded.

Original comment by mark.s.m...@gmail.com on 9 Oct 2013 at 3:20

GoogleCodeExporter commented 8 years ago
For Example I have:

klish-enable/Config/route.xml
klish-enable/Config/ip.xml
klish-enable/Config/users.xml

klish-enable/Show/route.xml
klish-enable/Show/ip.xml
klish-enable/Show/users.xml

With the current functionality of klish.  Those files will not load if you use 
a single xml path of klish-enable/

Original comment by mark.s.m...@gmail.com on 9 Oct 2013 at 3:23

GoogleCodeExporter commented 8 years ago
What do you think about -R (or -r) clish option to turn on recursive xml search?

Original comment by serj.kalichev@gmail.com on 14 Oct 2013 at 10:56

GoogleCodeExporter commented 8 years ago
I also like this feature.
I agree with adding a new command to turn on recursive search since we don't 
want to break existing behavior.

Original comment by corent...@gmail.com on 14 Oct 2013 at 5:02

GoogleCodeExporter commented 8 years ago
-r/-R works for me.  Backwards compatibility is always nice.

Original comment by mark.s.m...@gmail.com on 14 Oct 2013 at 6:35