search

palant / pfp

A simple and secure browser extension to be used with KeePass databases.
https://pfp.works/
Mozilla Public License 2.0
113 stars 14 forks source link

No visible feedback provided if sync.authorize() fails #104

Closed palant closed 1 year ago

palant commented 5 years ago

sync.authorize() can fail if remoteStorage is used as sync storage provider and the user address doesn't resolve using WebFinger. However, we close the pop-up immediately after calling sync.authorize(), so if an error occurs at this stage we cannot show it to the user any more.

I guess that authorization needs to be split into two stages, a preparation stage and actually requesting authorization from the user. We should only close the pop-up if the preparation stage succeeds. For sync storage providers other than remoteStorage the preparation stage can be a no-op, no real failure conditions there it seems.

palant commented 1 year ago

PfP 3.0 no longer has sync functionality, sync can be done externally.