search

palant / pfp

A simple and secure browser extension to be used with KeePass databases.
https://pfp.works/
Mozilla Public License 2.0
113 stars 14 forks source link

unable to sync with Google Drive #129

Closed warnat closed 1 year ago

warnat commented 1 year ago

Access blocked: PfP: Pain-free Passwords’s request is invalid ralf****@gmail.com You can’t sign in because PfP: Pain-free Passwords sent an invalid request. You can try again later, or contact the developer about this issue. Learn more about this error If you are a developer of PfP: Pain-free Passwords, see error details. Error 400: invalid_request

Do I miss some preparations to use google drive?

palant commented 1 year ago

Unfortunately, Google changed the way their API can be used, and our way of doing it is no longer working.

I no longer have time to maintain PfP and will be winding it down. This means in particular that this issue will no longer be fixed.

Maryse47 commented 1 year ago

@palant does it mean you found better alternative and stopped using it?

palant commented 1 year ago

No, it means that I cannot give it the attention it needs. From the look of it, I’ll be going with KeypassXC now. It lacks some features I need, but adding these should be less effort than continuing to develop a password manager of my own.

warnat commented 1 year ago

I see. Thanks for passing by.

Maryse47 commented 1 year ago

Ok, I'll stick with pfp which i consider superior to keepass and 99% feature complete.

palant commented 1 year ago

It also happens to need migrating to Manifest V3, otherwise it will stop working in Chrome fairly soon and in Firefox somewhat later.

Maryse47 commented 1 year ago

That sucks. Would migrating to v3 be much complicated for pfp? Maybe you can spare some last dance here :smile:

palant commented 1 year ago

I don’t know.

Interesting complication: manifest V3 support is only available as of Firefox 109. So it’s either not updating Firefox users or dropping compatibility with everything that isn’t the latest release.

Maryse47 commented 1 year ago

I think not updating would be fine when you don't add anything new in the end. At time ff drop old extension compat esr would have support for v3.

palant commented 1 year ago

That sucks. Would migrating to v3 be much complicated for pfp? Maybe you can spare some last dance here

I’m on it. However, I’m starting to seriously wonder whether I’m doing anyone a favor with it. Most of the changes are pretty straightforward, but background page turning into a service worker is just…

Altogether, the changes are definitely too extensive for the web version of the application. I would have to build extensions and the web version from different branches, the latter staying on Manifest V2 code – keeping them in sync would be yet again a considerable effort. At least the web version would be stable this way.

Edit: Just checked, and Chrome plans to drop Manifest V2 support in June 2023. I guess there isn’t much of a choice here…

Edit2: In fact, Firefox does not support storage.session, so there is no way to migrate to Manifest V3 there. Meaning: Chrome/Opera extension from the manifest-v3 branch, Firefox and web from main without any Manifest V3 changes.

Maryse47 commented 1 year ago

Thx, I'm grateful you spared some time for this. The v3 situation involves mixed feelings.

I think the June 2023 deadline in chrome is actually dropped: https://developer.chrome.com/docs/extensions/migrating/mv2-sunset/ https://groups.google.com/a/chromium.org/g/chromium-extensions/c/zQ77HkGmK9E https://groups.google.com/a/chromium.org/g/chromium-extensions/c/uIu9HjLD3_c

It sounds like it's too early to start v3 work as browsers aren't ready yet. At same time I understand you don't want to extend activity here over longer time.

PS. It's hard to believe it was 7 years(!)

Maryse47 commented 1 year ago

BTW: did you though about removing sync feature (gdrive/dropbox) from v2 (since it's broken anyway)? That would make extension totally offline and may cut some deps.

palant commented 1 year ago

The work is all done, see https://github.com/palant/pfp/tree/manifest-v3. Theoretically, we are all good. What’s missing are long-term experiences – whether the extension will continue working correctly, or whether the service worker will get stuck at some point. Question now is whether to release for Chrome from this branch or to do another MV2 release.

Edit: I think MV2 release for all platforms it is. Let’s hope that whenever MV3 becomes urgent I’ll find time to do a release from this branch.

No, I’m not removing sync. Dropbox sync is still working correctly for me, so I’m not sure how many users are affected by issues here. remoteStorage sync is also working fine.

palant commented 1 year ago

PfP 3.0 no longer has sync functionality, sync can be done externally.