palant / pfp

A simple and secure browser extension to be used with KeePass databases.
https://pfp.works/
Mozilla Public License 2.0
113 stars 14 forks source link

Issue #33 - Add password notes interface #34

Closed kzar closed 7 years ago

kzar commented 7 years ago

I've had a go at adding the interface required for password notes. Still a little rough and obviously it doesn't work since we can't store the notes yet. For now I've skipped adding a button to view / edit notes from the all passwords page.

palant commented 7 years ago

This looks good at first glance. Note that this will have to change anyway as we simply cannot keep adding icons for every action. After the next release (the one adding autofill for user names) we'll need to add some kind of overflow menu, and this is where this should go into.

kzar commented 7 years ago

@palant OK I've updated this now, sorry for the delay.

kzar commented 7 years ago

@palant addressed your comments, can you see my replies or do I need to click something to publish them?

kzar commented 7 years ago

@palant Updated again.

palant commented 7 years ago

This has been merged with https://github.com/palant/easypasswords/commit/eb6c6c72f422882d4af4c8d498e82d2c9f281c9c.