palant / pfp

A simple and secure browser extension to be used with KeePass databases.
https://pfp.works/
Mozilla Public License 2.0
113 stars 14 forks source link

android compatibility #37

Closed CircleCode closed 1 year ago

CircleCode commented 7 years ago

easy passwords is not presented on the android addons page. Do you plan to make it compatible with firefox for android?

palant commented 7 years ago

This is "nice to have" functionality as far as I am concerned. Mobile isn't my personal priority right now, and Firefox for Android isn't exactly a well-supported platform. Neither Web Extensions nor Add-on SDK have any user interface integration on Android (see http://arewewebextensionsyet.com/ and https://developer.mozilla.org/en-US/Add-ons/SDK/Tutorials/Mobile_development#High-Level_APIs).

CircleCode commented 7 years ago

I understand and respect this point of view.

However, since data could be synchronized through firefox sync, even a simplified version allowing only to get passwords would be nice for people using both desktop and mobile. Until this minimalist version exists, I hope I will be able to have the single page version available on my phone to enter generated passwords when I am on mobile

palant commented 7 years ago

Sync is not going to be a problem (see #24), but even displaying a page action would be. Either way, I asked on Mozilla Discourse, maybe there is something I'm missing here.

CircleCode commented 7 years ago

thanks for your interest, and your comprehension :-) I hope there will be some solution, even a minimalist one

palant commented 7 years ago

Looking at https://bugzilla.mozilla.org/show_bug.cgi?id=1263005, it seems that page actions are actually supported to some degree in Web Extensions starting with Firefox 50 but documentation hasn't been adjusted yet. That's a start and could actually allow a limited version to work even though chrome.tabs API really isn't supported.

CircleCode commented 7 years ago

not sure this would be of any help, but the panel ublock origin 1 shows in desktop is implemented as a new tab in mobile. Don't know how they achieve it, but this could be a path.

palant commented 7 years ago

Ok, I've hit https://bugzilla.mozilla.org/show_bug.cgi?id=1300807 immediately - page actions don't seem to be usable just yet. I've also noticed https://bugzilla.mozilla.org/show_bug.cgi?id=1300808 which is somewhat less critical. Altogether, WebExtensions don't seem to be ready on Android, not even for a very limited solution.

uBlock is escaping the Add-on SDK sandbox and going for low-lever browser APIs directly. As I mentioned on Discourse, this is a last resort but not a future-proof solution.

CircleCode commented 7 years ago

thanks at least for trying so quickly (I ❤️ open source!) for uBlock solution, I was hoping they were using another way, but as you said this is not future proof at all So I supose this feature will remain open for history until some progress is done on firefox for android side, or until someone comes with some magical solution on discourse…

palant commented 7 years ago

Yes, I think that at the current stage investing effort into Firefox on Android makes little sense - the time would be better spent packaging up https://palant.github.io/easypasswords/online.html as an Android app and adding syncing to it so that the process isn't quite as manual.

CircleCode commented 7 years ago

Maybe this page could be packgd as a web app with the following features:

This would be sufficient to allow mobile users to use their passwords on their mobile

palant commented 6 years ago

There is a fully featured web client under https://pfp.works/webclient/ now, and there will be downloadable packages for it once the next release is out. That's a good first step towards an Android client. Usability can be improved in a few places, particularly #52 should help quite a bit. And getting #24 done is a must-have.

r-a-y commented 6 years ago

Thanks for this, @palant.

Worth mentioning is that you can use the Easy Passwords addon on Firefox for Android. I've been using this already with success.

palant commented 6 years ago

I know. There are some minor issues (#60 and #61) that I hope to still get fixed before the next release, but for most part it works just fine. Unfortunately, not a viable option for most people.

charliemb2 commented 6 years ago

I was able to install Firefox for Anroid today, just for the purpose of installing and trying Easy Passwords based on this thread. To my surprise, I found Pain-Free Passwords instead. I installed it successfully. Will it work or should I attempt to find Easy Passwords? -Thanks

palant commented 6 years ago

Pain-Free Passwords is the new name of the Easy Passwords extension.

Noitidart commented 5 years ago

We should use react-native and create an app out of this for iOS and Android.

palant commented 5 years ago

We should use react-native and create an app out of this for iOS and Android.

And now we have two problems.

No, we don't need to switch to React for Android support. There is Cordova, meaning that packaging a web application for Android is fairly simple.

Noitidart commented 5 years ago

Oh that's true. The reason I had that idea, on iOS (im on iOS 9) Safari browser doesn't support the APIs needed. Cordova would just be a webview. I was thinking of making use of the native modules in react-native.

palant commented 5 years ago

Cordova also allows adding native code if needed. However, given how messed up the Apple ecosystem is, I don't expect us to target iOS any time soon.

Noitidart commented 5 years ago

Ohh cool re native code on Cordovoa.

I totally agree with you, Apple ecosystem is absolutely trash. Trying to get an app submitted to the store requires all kinds of ridiculous leg work.

mekineer commented 5 years ago

Kiwi web browser works with Chrome extensions.

David263 commented 1 year ago

If you made a Web-based solution to this issue that could decrypt the pfp passwords locally for manual use, perhaps using Ajax if necessary, then desktop users of pfp could still access their passwords on ANY other device, including iOS and Android. Just one page, running in almost any browser, could do the job without Web extensions or anything else fancy. Manual copying and pasting of passwords is much better than nothing. Just my opinion, but I hope you agree.

palant commented 1 year ago

As of PfP 3.0, we now use KeePass database format. Which means: any KeePass-compatible app can be used on Android, I no longer have to provide one.