search

palant / pfp

A simple and secure browser extension to be used with KeePass databases.
https://pfp.works/
Mozilla Public License 2.0
114 stars 14 forks source link

"Generate new password for this user name" button shouldn't be listed for legacy passwords #39

Closed kzar closed 8 years ago

kzar commented 8 years ago

So that a new password can be generated for a record without changing its user name or other details we have a revision field. The "Generate new password for this user name" button allows the revision to be conveniently adjusted for a record.

Since the revision field serves no purpose for legacy passwords it seems wrong to display the "Generate new password for this user name" button for them.

palant commented 8 years ago

No, having this button for legacy passwords is intentional - e.g. you might want to replace a legacy password with a generated one, this button will generate a password with default parameters and revision number 2. So unless this doesn't work correctly this issue is invalid.

kzar commented 8 years ago

Ah right, sorry I assumed it would bump the revision of the existing password.