palant / pfp

A simple and secure browser extension to be used with KeePass databases.
https://pfp.works/
Mozilla Public License 2.0
113 stars 14 forks source link

UI broken in latest nightly 55.0a1 (2017-06-02) (64 bits) #54

Closed CircleCode closed 7 years ago

CircleCode commented 7 years ago

I'm using firefox nightly (currently 55.0a1 (2017-06-02) (64 bits)) and the UI is totally broken:

ui

palant commented 7 years ago

This is not what I see here using the same nightly build. Could you try disabling other extensions to verify that none of them is interfering? Other than that, if you enter about:support into the location bar and copy the info it might be helpful.

CircleCode commented 7 years ago

I tested in a new empty profile with no other extensions, and the same occurs. Here is my about:support (sorry, it's in French :-()


edit: removed verbose about:suport since the problem has been found to be related to the locale.

palant commented 7 years ago

Ah, now I got it - EasyPasswords doesn't have a French locale, and localization doesn't fall back to English for some reason, so all strings are missing. This is weird, seems to be a Firefox bug.

CircleCode commented 7 years ago

I'm glad you reproduced it. If you want me to make some tests, feel free to ask.

palant commented 7 years ago

Yes, it is reproducible in Nightly but not Firefox 53 - so it's a Firefox regression. I'll need to look into it and report the bug to Mozilla.

CircleCode commented 7 years ago

thanks for your investigations. In the meantime, since the UI hard to use this way, is there:

palant commented 7 years ago

You can go to about:config and change general.useragent.locale preference to en-US. This shouldn't change anything for your browser (there is only a French locale), but extensions should be switched over to English.

palant commented 7 years ago

I can still reproduce this bug in the current nightly (56.0a1 2017-07-07). However, Web Extensions builds are not affected, everything works fine there. So I'll say that https://github.com/palant/easypasswords/commit/cbff1737415f3ee42ed511a2679e09bab38a5e75 fixes this issue - classic builds are no longer supported, and I will release Easy Passwords as a Web Extension soon.

CircleCode commented 6 years ago

I can confirm this has been solved by today's upgrade, thanks

palant commented 6 years ago

The version based on Web Extensions isn't quite out yet, but I'm glad to hear that the issue has been resolved (via a change in Nightly I guess?).

CircleCode commented 6 years ago

I updated nightly this morning, so I suppose this is related (I thought you updated the version, but it is in fact still marked as obsolete, so this is definitely not the web extension version).

palant commented 6 years ago

For reference, Easy Passwords 1.2 has been released yesterday - that's the first Web Extensions based version. It should be through AMO review soon.