Door hanger doesn't work in permanent private browsing mode

palant / pfp

A simple and secure browser extension to be used with KeePass databases.

https://pfp.works/

Mozilla Public License 2.0

113 stars 14 forks source link

Door hanger doesn't work in permanent private browsing mode #92

Closed fmarier closed 5 years ago

fmarier commented 6 years ago

If you go into about:preferences#privacy and set:

Firefox will Never, remember history

Then the icon that opens the PfP doorhanger doesn't work. The door hanger never actually opens.

roguh commented 5 years ago

I was unable to reproduce this bug on Firefox 61.0.2. The door hanger opens and seems to save its state even after I close tabs and windows. I could try an older version to try to reproduce this on 64-bit Linux.

palant commented 5 years ago

For me, the icon simply didn't appear. That's because you have to explicitly allow the extension in private windows. To do that, go to about:addons and select the extension. Under "Run in Private Windows" select "Allow." After that, everything seems to be working.

I now added an incognito setting to the extension's manifest but I don't think it will really change anything - this needs to be enabled manually in Firefox.