search

palant / pfp

A simple and secure browser extension to be used with KeePass databases.
https://pfp.works/
Mozilla Public License 2.0
113 stars 14 forks source link

Better UI #94

Closed roguh closed 5 years ago

roguh commented 5 years ago

Are there any plans for improving the user interface?

Although I think the interface is well thought-out, I think it could still use some graphical improvements. The only actual issue I have is that the addon does not work well on Firefox on Android; the door hanger is actually opened in another tab so everything looks too small.

I plan to work on some improvements I have in mind, including on fixing this issue on Android. I'm posting this issue to keep track of any progress on this.

roguh commented 5 years ago

Here are some screenshots:

screenshot_20180821-220338 screenshot_20180821-220252

palant commented 5 years ago

The scaling seemed fine to me when I tried the extension on Firefox for Android, but I'll try again to see whether I can reproduce this issue. In general, more significant UI changes are planned. In particular, I want a tool selection on the left side indicating where you are right now - search, password list or sync settings.

adrium commented 5 years ago

What do you think about the interface of https://github.com/adrium/easypass ? (Try the chrome extension)

palant commented 5 years ago

I suggest that you stop spamming. This is largely about the way the user interface looks in Firefox Mobile - which is the only mobile browser to support extensions. You are free to do your Chrome-only fork, but please don't add noise to my issues.

roguh commented 5 years ago

Pardon me. Feel free to delete this issue

roguh commented 5 years ago

Wait, I thought you were calling the issue spam, not the comment.

As an update, I think #91 might be a more general fix. I only want a way to access this password manager on mobile.

On another note, the Firefox UX is almost ok. When I tap on any text input, the display zooms in to a reasonable level.

roguh commented 5 years ago

This was most recently reproduced on Firefox Beta 63.09b on Android.

palant commented 5 years ago

Sorry about it, when I talked about spam I meant https://github.com/palant/pfp/issues/94#issuecomment-425643201 of course.

javenschuetz commented 5 years ago

my 2 cents on the UI is that some minimal keyboard shortcuts would be an important addition. IIRC, bitwarden uses ctrl+shift+L to auto-fill and it makes a huge difference in usability. I don't really care about a fancy ui besides this.

(Pardon me if the shortcut already exists, I spent some time trying to find it earlier today and even grepped through the codebase very briefly)

palant commented 5 years ago

Landed a massive change refactoring the panel on top of the Vue.js framework. This is an important prerequisite for UI improvements as the complexity was getting prohibitive here. Also, some UI improvements have been implemented in this step already, e.g. quite a few UI pieces are modal overlays now.

Pardon me if the shortcut already exists

See https://github.com/palant/pfp/issues/43#issuecomment-450913930

palant commented 5 years ago

Forgot to reference this issue in https://github.com/palant/pfp/commit/087a285c56839964e8b1924c8a9068ef56129b53, it belongs here.

palant commented 5 years ago

Here is how it looks now:

screenshot

palant commented 5 years ago

And slightly differently now after addressing #101 (website name is a link):

screenshot

palant commented 5 years ago

The scaling issue as reported initially should be fixed as well now.

palant commented 5 years ago

Unfortunately, I don't see any way to improve display of options, this one is controlled by Firefox itself. When viewing options within PfP user interface, it works fine however.

jotaf98 commented 5 years ago

The new UI looks great! When can we expect it to land?

Perhaps more importantly, does it fix the scaling issues in Firefox for Android? The addon is pretty functional there, but having to zoom in PfP's overlay on an otherwise mobile-friendly page to click tiny buttons is not great.

palant commented 5 years ago

As I said above:

The scaling issue as reported initially should be fixed as well now.

I hope to have the release ready within two weeks, there are still two major changes outstanding.

jotaf98 commented 5 years ago

Alright, sorry I missed that part. Glad to hear it! Thanks for the amazing password manager by the way!

Auronius commented 5 years ago

I hope to have the release ready within two weeks, there are still two major changes outstanding.

I already merged all my passwords to PfP. I am waiting for new release with updated interface.

Thanks for the amazing password manager by the way!

Yes, PfP is great password manager!