palant / pfp

A simple and secure browser extension to be used with KeePass databases.
https://pfp.works/
Mozilla Public License 2.0
113 stars 14 forks source link

Vivaldi browser: auto-lock fails #99

Closed alikve closed 5 years ago

alikve commented 5 years ago

I use PfP in the Vivaldi browser (Linux, 64 bit). Everything works except the auto-lock with positive delay. The delay 0 works. Also manual "Lock passwords" works. Restarting browser locks as it should.

On the same computer for Firefox and Google Chrome auto-lock works.

palant commented 5 years ago

Confirmed in Vivaldi 2.5.1525.43 on Linux.

palant commented 5 years ago

It's a weird quirk in Vivaldi - while the pop-up disappears, it doesn't actually unload. So the pop-up's port doesn't disconnect, there is no pagehide or unload event. AFAICT there is no way of telling that the pop-up is no longer visible. And since as far as PfP is concerned the pop-up is still active, autolock won't kick in. Only when you open the pop-up again the previous pop-up instance unloads which allows autolock to work - only if delay is 0 of course, because the new instance loads immediately after that.

I have no idea why it has been implemented in this way, it could simply be a bug. I filed a Vivaldi bug report VB-53559 on this.

palant commented 5 years ago

Closing as rejected because there doesn't seem to be anything I can do about this, this being a Vivaldi bug.