search

palantir / atlasdb

Transactional Distributed Database Layer
https://palantir.github.io/atlasdb/
Apache License 2.0
54 stars 9 forks source link

Transaction and namespace tables unreadable from Shell/Console #1457

Open clockfort opened 7 years ago

clockfort commented 7 years ago

it's useful to be able to examine these tables while debugging from shell/console, but since they have fake timestamps they're unreadable from shell/console that lives on top of the transactions layer.

We previously had a hack in SnapshotTransaction to skip postfiltering of read rows (that look like they should be considered unreadable according to our transaction model) from the transaction and namespace tables.

Petracca accidentally obliterated the hack in a cleanup while getting rid of temp table usage.

Suggest either putting the hack back into SnapshotTransaction , or maybe making a slightly better version, maybe with some special opt-in transaction type used for debugging that would allow the user to read/have returned to her all of the unreadable rows (i.e. no filtering), which has the additional benefit that it could be used for debugging weird issues on tables besides the transaction and namespace ones.

jboreiko commented 7 years ago

Change being referenced above. You can see the removal of the check in SnapshotTransaction. https://github.com/palantir/atlasdb/pull/916/files

gsheasby commented 7 years ago

@clockfort happy to accept a PR; are you planning on tackling it this/next week yourself?