search

palantir / atlasdb

Transactional Distributed Database Layer
https://palantir.github.io/atlasdb/
Apache License 2.0
54 stars 10 forks source link

Trace ID support on TimeLock #1765

Open jeremyk-91 opened 7 years ago

jeremyk-91 commented 7 years ago

See internal comments on PDS-50991.

If a timelock client request fails and its request includes a trace ID, it would be useful to have this trace ID on server logs as well. I'm not entirely sure what this would entail in terms of implementation, but it looks like http-remoting has a fair bit of infrastructure to handle this.

rhero commented 7 years ago

We definitely want to add something like this, but the question is whether or not we want to take on moving to http-remoting and doing away with our own custom http client. Going to file a new ticket to track the decision to move to http-remoting.

hsaraogi commented 7 years ago

Blocked on #1999.

hsaraogi commented 7 years ago

Blocked on #1766.

hsaraogi commented 7 years ago

After switching to remoting3, we should consider using the remoting client and get tracing for free.