PR #1796 shadowed some remoting2 libraries, but there are some issues with the PR: in particular, trying to actually serialize or deserialize exceptions may not work because we don't enforce that the client has some Jackson modules that http-remoting expects. In particular, we need to either add as a dependency or shadow the JDK 8 and JSR 310 modules.
I'm fine with either option. The pros of adding as a dependency is that this would be consistent with our current requirement for the JDK 7, Guava and Afterburner, though I generally try to be a bit wary of expanding our dependency footprint too much. Shadowing could work but would bump the jar size and may also lead to weird errors if we're using incompatible versions of Jackson.
This was uncovered in PR #1808 when ETE tests led to ClassNotFoundErrors for the Jdk8Module.
jeremyk-91
commented
7 years ago
PR #1796 shadowed some remoting2 libraries, but there are some issues with the PR: in particular, trying to actually serialize or deserialize exceptions may not work because we don't enforce that the client has some Jackson modules that http-remoting expects. In particular, we need to either add as a dependency or shadow the JDK 8 and JSR 310 modules.
I'm fine with either option. The pros of adding as a dependency is that this would be consistent with our current requirement for the JDK 7, Guava and Afterburner, though I generally try to be a bit wary of expanding our dependency footprint too much. Shadowing could work but would bump the jar size and may also lead to weird errors if we're using incompatible versions of Jackson.
This was uncovered in PR #1808 when ETE tests led to
ClassNotFoundErrors for the Jdk8Module.