palantir / atlasdb

Transactional Distributed Database Layer
https://palantir.github.io/atlasdb/
Apache License 2.0
53 stars 9 forks source link

Live reloading configs #1965

Open fsamuel-bs opened 7 years ago

fsamuel-bs commented 7 years ago

AtlasDB, both client and timelock-server, should support live reloaded configs - this is, changes on configs after the service has started should be reflected on the behavior of the application.

hsaraogi commented 7 years ago

Partially fixed by #1976.

gsheasby commented 6 years ago

This could be finished off early next year by adding live reloading for KVS config.

Comment from @tboam: "The KVS config which includes the list of C* servers is not currently live reloaded. I actually think the Cassandra Client Pools code supports this and we just need to move it to the runtime config and wire it up. Will prioritise for very early next year. We need to figure out if there's anything that can't be live reloaded."

hsaraogi commented 6 years ago

Ensure all Atlas config is live-reloadable or have a good reason for why some blocks arent.

gsheasby commented 6 years ago

The following sections of the config are not live reloaded:

So the remaining work here is to move the four individual variables to AtlasDbRuntimeConfig, and to create a live-reloadable ScrubConfig block (assuming these variables would actually be used by someone).