palantir / atlasdb

Transactional Distributed Database Layer
https://palantir.github.io/atlasdb/
Apache License 2.0
55 stars 11 forks source link

C* KVS should throw InsufficientConsistencyException #4089

Open gmaretic opened 5 years ago

gmaretic commented 5 years ago

When a C* node is down, and a KVS operation that requires all nodes is called, we eventually throw a RetryLimitReachedException. We should identify when the cause for this failure is insufficient consistency by checking the suppressed exceptions and throw an InsufficientConsistencyException instead, since there are places in our codebase where we are relying on catching ICE for proper behaviour.

gmaretic commented 5 years ago

One way this is manifesting is TS failing with generic error rather than not enough nodes online