palantir / atlasdb

Transactional Distributed Database Layer
https://palantir.github.io/atlasdb/
Apache License 2.0
47 stars 8 forks source link

[JUnit5] Oracle ETE tests flup #6969

Closed barisoyoruk closed 5 months ago

barisoyoruk commented 6 months ago

My leftover work from junit5 project.

barisoyoruk commented 6 months ago

My findings:

The weird thing is that we create the test table just before truncating. If the create succeeds, then I don't understand why truncate fails with saying that there is no such table.

Some trivia:

barisoyoruk commented 5 months ago

I found the problematic class is OracleAlterTableIntegrationTest and function

    @AfterEach
    public void after() {
        defaultKvs.dropTables(defaultKvs.getAllTableNames());
        defaultKvs.dropTable(DbKvsOracleExtension.getKvsConfig().ddl().metadataTable());
        connectionSupplier.close();
    }

Since it is dropping metadata table, the following tests fail to find short name mapping for the test table. I added Order(Integer.MAX) value to this class but it is still running before other tests. I am not sure if it is Junit5 issue or I am missing something. I will deal with this PR in the future.