changelog-app[bot]
commented
7 months ago Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir
What do the change types mean?
- `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._How are new versions calculated?
- ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.Type
Description
jeremyk-91
svc-autorelease
General
Before this PR: Some internal users pull in AtlasDB despite not actually using it, but instead wanting a lock or timelock service. They currently have to create an AtlasDB service, even if they don't use the KVS. Alternatively, they just pull in
atlasdb-config, but they then need to construct their own client, and they need to copy from AtlasDB all of the client creation logic.After this PR: ==COMMIT_MSG== Users who wish to use a lock service only (and not full AtlasDB) may create a standalone service. ==COMMIT_MSG==
Priority: P2
Concerns / possible downsides (what feedback would you like?):
Is documentation needed?: No.
Compatibility
Does this PR create any API breaks (e.g. at the Java or HTTP layers) - if so, do we have compatibility?: No
Does this PR change the persisted format of any data - if so, do we have forward and backward compatibility?: No
The code in this PR may be part of a blue-green deploy. Can upgrades from previous versions safely coexist? (Consider restarts of blue or green nodes.): Yes
Does this PR rely on statements being true about other products at a deployment - if so, do we have correct product dependencies on these products (or other ways of verifying that these statements are true)?: No
Does this PR need a schema migration? No
Testing and Correctness
What, if any, assumptions are made about the current state of the world? If they change over time, how will we find out?: That this is what we want
What was existing testing like? What have you done to improve it?: Testing
If this PR contains complex concurrent or asynchronous code, is it correct? The onus is on the PR writer to demonstrate this.: It doesn't
If this PR involves acquiring locks or other shared resources, how do we ensure that these are always released?: It doesn't
Execution
How would I tell this PR works in production? (Metrics, logs, etc.): Such clients work
Has the safety of all log arguments been decided correctly?: No new args
Will this change significantly affect our spending on metrics or logs?: No
How would I tell that this PR does not work in production? (monitors, etc.): Clients don't work
If this PR does not work as expected, how do I fix that state? Would rollback be straightforward?: Rollback
If the above plan is more complex than “recall and rollback”, please tag the support PoC here (if it is the end of the week, tag both the current and next PoC):
Scale
Would this PR be expected to pose a risk at scale? Think of the shopping product at our largest stack.: I don't think so
Would this PR be expected to perform a large number of database calls, and/or expensive database calls (e.g., row range scans, concurrent CAS)?: No
Would this PR ever, with time and scale, become the wrong thing to do - and if so, how would we know that we need to do something differently?: Users of internal AtlasDB proxy probably deserve a cleaner interface.
Development Process
Where should we start reviewing?: Small
If this PR is in excess of 500 lines excluding versions lock-files, why does it not make sense to split it?: It's not
Please tag any other people who should be aware of this PR: @jeremyk-91 @sverma30 @tpetracca