search

palantir / atlasdb

Transactional Distributed Database Layer
https://palantir.github.io/atlasdb/
Apache License 2.0
53 stars 9 forks source link

allow user of InMemoryKeyValueService to override the default OverwriteBehaviour #6996

Closed rhuffy closed 7 months ago

rhuffy commented 7 months ago

General

Before this PR: InMemoryKeyValueService throws a KeyAlreadyExistsException if two puts for the same Cell and timestamp are submitted with different values. This doesn't match the behavior of Cassandra, where unless putUnlessExists is used, the database will tolerate puts on the same Cell+timestamp.

After this PR: I'd like the InMemoryKeyValueService to have the same behavior as CassandraKeyValueServiceImpl, so this PR allows you to override the OverwriteBehaviour used in put and putWithTimestamps to OVERWRITE instead of OVERWRITE_SAME_VALUE, which should match the behavior of Cassandra.

==COMMIT_MSG== allow user of InMemoryKeyValueService to override the default OverwriteBehaviour ==COMMIT_MSG==

This is not a breaking change, and is solely used by my test code.

changelog-app[bot] commented 7 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [x] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

allow user of InMemoryKeyValueService to override the default OverwriteBehaviour **Check the box to generate changelog(s)** - [x] Generate changelog entry